isInCombat returning incorrectly?

[Rubick 30]

I have a checker before attacking an NPC:

if (!chicken.isInCombat()) {
                    chicken.interact("Attack")) 
                    }
                

Why is it still attacking chickens already in combat with other players?

[Pyth 127]

You should be able to do this for now.

if (!chicken.isInCombat() && !chicken.isInteractedWith()) {

[Genius 43]

I have a checker before attacking an NPC:

if (!chicken.isInCombat()) {
                    chicken.interact("Attack")) 
                    }
                

Why is it still attacking chickens already in combat with other players?

 

Likely because when you declared the chicken object it wasn't in combat, though it could be broken. Is your chicken being updated (looped over)? Using a filter instead might be easier.

 

Edit: If it is broken try adding Noodle's suggestion to the filter.

//I didn't type this in an IDE so you might need to fix a syntax error or two =)
NPC chicken = getNpcs().closest(c -> c != null && c.getName().equals("Chicken") && !c.isInCombat);
if (chicken != null && !getLocalPlayer.isInCombat())
  chicken.interact("Attack");

Edited August 1, 2017 by Genius

[Rubick 30]

 

You should be able to do this for now.

if (!chicken.isInCombat() && !chicken.isInteractedWith()) {

 

Is IsInCombat() working as intended or is that part of the API bugged? Thanks for the work around.

[Genius 43]

Is IsInCombat() working as intended or is that part of the API bugged? Thanks for the work around.

 

Run a script with this in your onLoop to test then just fight some stuff:

@Override
    public int onLoop() {
        log("In combat: " + String.valueOf(getLocalPlayer().isInCombat()));
        return 1000;
    }

[Rubick 30]

 

Run a script with this in your onLoop to test then just fight some stuff:

@Override
    public int onLoop() {
        log("In combat: " + String.valueOf(getLocalPlayer().isInCombat()));
        return 1000;
    }

 

Ah, good thinking. I'll test this out tomorrow. Got the script running with 's fix to see if that works out of curiosity first.

Edited August 1, 2017 by Rubick

[Pandemic 2339]

Checking it out

Seems to be working for me, if you find any scenarios where it's wrong let me know

[Manly 878]

Checking it out

Seems to be working for me, if you find any scenarios where it's wrong let me know

 

I have a filter such as this:

final Player p = getPlayers().closest(player -> player != null && player.exists() && player.isInCombat() && player.getInteractingCharacter() != null && player.isInteracting(getLocalPlayer()));

It returns true even though the player trades me instead of attacking in the wilderness.

[Pandemic 2339]

I have a filter such as this:

final Player p = getPlayers().closest(player -> player != null && player.exists() && player.isInCombat() && player.getInteractingCharacter() != null && player.isInteracting(getLocalPlayer()));

It returns true even though the player trades me instead of attacking in the wilderness.

 

 

There's no way we can differentiate between attacking / trading, they both just show as interacting with (our basis for isInCombat).

[Manly 878]

There's no way we can differentiate between attacking / trading, they both just show as interacting with (our basis for isInCombat).

 

#isInCombat checks for interaction? I guess I should add a check for health bar visibility.