isOnScreen() is terribly inefficient.

[Dorkinator 64]

						List<Player> players = getPlayers().all(new Filter<Player>() {

							@Override

							public boolean match(Player i) {

								return i != null && i.getName() != null;

							}

						});

						long st = System.nanoTime();

						for(Player i:players){

							i.isOnScreen();

						}

						System.out.println("isOnScreen "+ (st-System.nanoTime()));


						st = System.nanoTime();

						for(Player i:players){

							Point p = getClient().getViewport().tileToScreen(i.getTile());

							if(new Rectangle(100,100,100,100).contains(p)){

								p.getY();

							}

						}

						System.out.println("stupidMethod "+ (st-System.nanoTime()));

isOnScreen -21865801

stupidMethod -11401

isOnScreen -24470355

stupidMethod -7894

isOnScreen -18455235

stupidMethod -11109

isOnScreen -27057369

stupidMethod -9648

isOnScreen -18955740

stupidMethod -7601

isOnScreen -20542620

stupidMethod -8478

isOnScreen -18806057

stupidMethod -8479

isOnScreen -23592425

stupidMethod -11110

isOnScreen -22928497

stupidMethod -9940

Generating the point and checking if it's in a rectangle is 4 order of magnitude more efficient.

[AHappyHippo 3]

I stopped using it likely because I tracked half my bugs down to it not working. Nice work demonstrating the issue! THIS is how things get changed

[Noidlox 11]

This will probably be fixed in Dreambot 3.0

[Nex 2546]

yea bugged for me aswell

[Manly 879]

So are you saying something like this is better to use than the on screen method in the API?

private boolean isOnScreen(final NPC npc) {
    if (npc == null) {
        return false;
    }

    Point p = getClient().getViewport().tileToScreen(npc.getTile());
    return (new Rectangle(1, 1, 515, 338).contains(p));
}

[Dorkinator 64]

So are you saying something like this is better to use than the on screen method in the API?

private boolean isOnScreen(final NPC npc) {
    if (npc == null) {
        return false;
    }

    Point p = getClient().getViewport().tileToScreen(npc.getTile());
    return (new Rectangle(1, 1, 515, 338).contains(p));
}

 

I'm saying that you should never use isOnScreen because of how long it takes to execute.

[Pandemic 2853]

isOnScreen calculates the model area and checks if it intersects with the viewport area, so of course it'll be slower than using a less precise check like tileToScreen.

 

However the small difference probably isn't worth the extra processing power, so I'll give it a look

[Manly 879]

I'm saying that you should never use isOnScreen because of how long it takes to execute.

Ive started using the method i posted and not sure if its a placebo effect, but I feel the difference.

[Dorkinator 64]

isOnScreen calculates the model area and checks if it intersects with the viewport area, so of course it'll be slower than using a less precise check like tileToScreen.

 

However the small difference probably isn't worth the extra processing power, so I'll give it a look

That's all we can ask for.