Gorn

It's not Dreambot. OSRS is down.

ok I will take a shot at it if (!getInventory().isFull()) { //code } if(getInventory().isFull()){ //code } You could just have else there if (treeArea != null) { log("treeArea Chest is not null."); } else { log("treeArea Chest is null."); } treeArea is your own variable that you define at the top, how could it be null? if (getWalking().walk(treeArea.getRandomTile())) you don't need to get a new random tile every time you call the walk function @Override public void onPaint(Graphics graphics) { } Why are you posting an empty function? sleepUntil(() -> getInventory().count("Logs") > countLog, 12000); if somebody else gets the tree before you the bot will just stand there until the sleepUntil times out also sleepUntil is a performance hog GameObject chest = getGameObjects().closest(c -> c != null && c.getName().contains("Bank chest") && c.hasAction("Use")); Your code is written to only handle chests, why? There are 4 types of banks as you can see here https://dreambot.org/javadocs/org/dreambot/api/methods/container/impl/bank/BankType.html so let DreamBot handle this for you and write something like BankLocation anyTypeOfBank = getBank().getClosestBankLocation(); getBank().open(anyTypeOfBank); that way it will open the nearest bank regardless of the type if (chest.interact("Use")) { sleepUntil(() -> getBank().isOpen(), 2000); } sleepUntil(() -> !getInventory().contains(item -> item != null && item.getName().contains("Magic logs")), 2000); You use sleepUntil to check if the bank is open and also to check if the logs were already deposited. That's pretty expensive way of doing it. while(!getBank().isOpen()){ sleep(500); } This is essentially the same thing but without the performance hit, although it really only matters if you intend to run many bots.

That's what I was looking at and didn't realize you have to write it twice like getGroundItems().getGroundItems(lootTile) Basically there are 2 different functions both named getGroundItems and I didn't realize it right away. Especially confusing when you need to chain them like this.

GroundItem[] loot = manager.getGroundItems().getGroundItems(lootTile); Can you rename this to something like 'getGroundItemsOnTile'? I was just banging my head on why getGroundItems doesn't take Tile type, but you can't rename it cause it would break old code right? It's pretty confusing for newcomers