TSalmon w/ SourceCode

[Donald Trump 333]

Here's a small script I made a while back, used it a few times initially but not anymore. Apparently it's broken but I'm not gonna maintain it. Here's the source for anyone wanting to see how I coded this.

 

Basically the script has an emphasis on anti pattern and just fished the salmon at lummy and dropped them. If you want to suggest any code changes I welcome those below.

 

Source:

import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import java.io.IOException;

import javafx.scene.control.Separator;
import org.dreambot.api.methods.map.Area;
import org.dreambot.api.methods.map.Tile;
import org.dreambot.api.methods.skills.Skill;
import org.dreambot.api.methods.tabs.Tab;
import org.dreambot.api.script.Category;
import org.dreambot.api.script.ScriptManifest;
import org.dreambot.api.script.AbstractScript;
import java.awt.*;
import javax.imageio.ImageIO;
import javax.swing.*;

import org.dreambot.api.script.listener.AdvancedMessageListener;
import java.net.URL;
import org.dreambot.api.methods.Calculations;
import java.util.ArrayList;
import java.util.Random;

import org.dreambot.api.script.listener.InventoryListener;
import org.dreambot.api.utilities.Timer;
import org.dreambot.api.wrappers.interactive.NPC;
import org.dreambot.api.wrappers.items.Item;
import org.dreambot.api.wrappers.widgets.WidgetChild;
import org.dreambot.api.wrappers.widgets.message.Message;

@ScriptManifest(author = "Donald Trump", category = Category.MISC, name = "TSalmon", version = 1.0, description = "...")
public class main extends AbstractScript implements InventoryListener {

    private Timer timer = new Timer();
    private Timer timer2 = new Timer();
    private boolean anti;
    private boolean anti2;
    private int timetoanti = randInt(120000, 200000);
    private Area fisharea = new Area(3242, 3240, 3240, 3251);
    private int count;

    public enum State {
        nothing, stop_script, drop, fish, antiban, wait, dialog, selfheal
    }

    private State getState() {

        if (!getClient().isLoggedIn()) {
            return State.nothing;
        } else if (getInventory().isItemSelected()) {
            return State.selfheal;
        } else if (getDialogues().canContinue()) {
            return State.dialog;
        } else if (getLocalPlayer().getAnimation() == 623) {
            if (timer2.elapsed() > timetoanti) {
                return State.antiban;
            } else {
                return State.wait;
            }
        } else if (!getClientSettings().isShiftInteractionEnabled()) {
            return State.stop_script;
        } else if (getInventory().isFull()) {
            return State.drop;
        } else if (!getInventory().contains("Feather")) {
            return State.stop_script;
        } else if (getInventory().contains("Feather", "Fly fishing rod")) {
            return State.fish;
        }


        return State.nothing;

    }

    @Override
    public int onLoop() {
        switch (getState()) {
            case selfheal:
                getMouse().click();
                break;
            case dialog:
                anti2 = true;
                int iii = randInt(1, 2);
                if (iii == 1) {
                    sleep(2500, 15000);
                    while (getClient().isLoggedIn() && getDialogues().canContinue()) {
                        getDialogues().continueDialogue();
                    }
                } else {
                    sleep(7500, 30000);
                    while (getClient().isLoggedIn() && getDialogues().canContinue()) {
                        getDialogues().continueDialogue();
                    }
                }
                break;
            case wait:
                anti = true;
                getMouse().moveMouseOutsideScreen();
                break;
            case antiban:
                int i = randInt(1, 5);
                Area random = Area.generateArea(6, getLocalPlayer().getTile());
                if (i == 1) {
                    getCamera().rotateToTile(random.getRandomTile());
                } else if (i == 2) {
                    getCamera().mouseRotateToTile(random.getRandomTile());
                } else if (i == 3) {
                    getTabs().open(Tab.STATS);
                    sleep(1500, 3400);
                    getTabs().open(Tab.INVENTORY);
                } else if (i == 4) {
                    Area random2 = Area.generateArea(1, getLocalPlayer().getTile());
                    getMouse().move(random2.getRandomTile());
                    sleep(1000, 3000);
                } else if (i == 5) {
                    NPC spot = getNpcs().closest("Fishing spot");
                    if (spot != null) {
                        int ii = randInt(1, 2);
                        if (ii == 1) {
                            if (spot.isOnScreen()) {
                                spot.interactForceLeft("Lure");
                            }
                        } else {
                            spot.interactForceRight("Lure");
                        }
                    }
                }
                timetoanti = randInt(120000, 300000);
                int log = timetoanti / 60000;
                log("NT: " + Integer.toString(log) + "minutes");
                timer2.reset();
                break;
            case fish:
                if (!anti2 && anti) {
                    sleep(7500, 25000);
                    anti = false;
                }
                if (!getTabs().isOpen(Tab.INVENTORY)) {
                getTabs().open(Tab.INVENTORY);
                }
                NPC fishspot = getNpcs().closest("Fishing spot");
                if (fishspot != null && fishspot.distance() < 10) {
                    int ii = randInt(1, 2);
                    if (ii == 1) {
                        if (fishspot.isOnScreen()) {
                            fishspot.interactForceLeft("Lure");
                        }
                    } else {
                        fishspot.interactForceRight("Lure");
                    }
                    sleepUntil(() -> getLocalPlayer().isInteractedWith(), Calculations.random(3000, 6000));
                } else {
                    getWalking().walk(fisharea.getRandomTile());
                    sleepWalk(Calculations.random(3, 6), Calculations.random(3000, 6000));
                }
                break;
            case drop:
                getInventory().dropAllExcept("Feather", "Fly fishing rod");
                break;
            case stop_script:
                log("Something went wrong, the script must stop.");
                stop();
                break;
            case nothing:
                break;

        } return Calculations.random(500,900);
    }


    @Override
    public void onStart(String... params) {

    }

    @Override
    public void onStart() {
        getSkillTracker().start(Skill.FISHING);
    }

    @Override
    public void onExit() {

    }

    @Override
    public void onPaint(Graphics g) {
        g.setFont(new Font("Arial", Font.BOLD, 12));
        g.setColor(Color.YELLOW);
        g.drawString("Runtime: " + timer.formatTime(), 25, 40);
        g.drawString("State: " + getState().name(), 25, 55);
        g.drawString("XP (HR): " + getSkillTracker().getGainedExperiencePerHour(Skill.FISHING), 25, 70);
        g.drawString("Fish Caught (HR): " + timer.getHourlyRate(count), 25, 85);
    }

    private boolean sleepWalk(int distance, int timeout) {
        return sleepUntil(() -> !getLocalPlayer().isMoving() || getLocalPlayer().distance(getClient().getDestination()) < distance, timeout);
    }

    private static int randInt(int min, int max) {
        Random rand = new Random();
        int randomNum = rand.nextInt((max - min) + 1) + min;
        return randomNum;
    }

    private void customSleep(boolean name) {
        sleepUntil(() -> name, Calculations.random(2000, 4000));
    }

    @Override
    public void onItemChange(Item[] items) {
        for (Item item : items) {
            if (item != null && item.getName().equals("Raw salmon") && item.getAmount() > 0) {
                count++;
            } else if (item != null && item.getName().equals("Raw trout") && item.getAmount() > 0) {
                count++;
            }
        }
    }
}

[dQw4w9WgXcQ 184]

nice script!

[Donald Trump 333]

nice script!

 

Any improvement suggestions?

[distraction 61]

Cool script, even cooler to post the source. It looks like you did a pretty good job! 

 

One thing I noticed is that I think you could replace 

getLocalPlayer().distance(getClient().getDestination()) < distance

with this to achieve the same thing in a more readable way, its not really a big deal either way though.

getWalking().shouldWalk(distance)

One other thing I noticed is that there aren't any comments. I usually try to comment my code as I write it, even if I'm the only one who will ever really see it. It makes it a lot easier to update/maintain when you come back to it months down the line. 

 

Anyway, thanks for posting the script/source!

[dQw4w9WgXcQ 184]

Any improvement suggestions?

 

 

There's a lot you can work on here.

 

 

The getState method can be greatly simplified.  A lot of the cases could be combined.  State.selfheal is actually just to deselect an item?  Cases stopscript, nothing, wait, dialog, and selfheal shouldn't be their own cases.  The only states you should have are FISH, DROP, ANTIBAN.  

 

In state.selfheal, just use getInventory.deselect().

 

In case dialogue, the while loop is really bad design and it will execute clickContinue() a shit ton until the loop ends.  Its unnecessary because even if the continue fails, the script will continue on the next onLoop. 

 

also you have unnecessary code duplication.  You could just sleep in the if/else and then continue dialogue after.  

 

the if/else block in state.antiban should be a switch.  case.wait could be incorporated into the antiban case.  idk what to say about these antiban methods.....

 

Even if you don't care about naming conventions, you should at least give your variables descriptive names.  For example, it would be easier to follow if you had named "timer" and "timer2" to "runtimer" and "antibanTimer".

 

The logic is spread out too much in your script.  Try to keep things modularized.  The antiban stuff is all over the place when it could just be in one method of the switch statement.  

 

Throughout your code, there are instances where you could achieve the same logic in a more concise statement.  An example of this would be instead of doing if(x){if(y)} do if(x && y).  You could really benefit from reading through some good code and picking up on the habits of better developers.  

[Eru 5]

      if (item != null && item.getName().equals("Raw salmon") && item.getAmount() > 0) {
                count++;
            } else if (item != null && item.getName().equals("Raw trout") && item.getAmount() > 0) {
                count++;
            }

This is really messy.

 

item.getName().equals("Raw salmon") Can still cause nullpointers.

 

item.getAmount() > 0 You cant add zero raw fish to your inventory right, isn't this unnecessary then?

        HashSet<String> rawFishNames = new HashSet<String>() {{
            add("Raw trout");
            add("Raw Salmon");
        }};
        
        if (item != null){
            String itemName = item.getName();
            if (itemName != null && rawFishNames.contains(itemName)) {
                count++;
            }
        }